[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus/variants/garg: support LTE power sequence.

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34188 )

Change subject: mb/google/octopus/variants/garg: support LTE power sequence.
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34188/6/src/mainboard/google/octopu... 
File src/mainboard/google/octopus/smihandler.c:

https://review.coreboot.org/c/coreboot/+/34188/6/src/mainboard/google/octopu... 
PS6, Line 37: gpio_get_output
> Just curious: can we not use sku id to determine if it is a LTE SKU and then do the power off sequen […]

Just realized that this is in the mainboard and checking for sku will not work.

Another option is to introduce a octopus wide flag which indicates the presence or absence of lte module and then set it at the variants which have the lte module. Then use the state of that flag here to power off lte modules.