Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86166?usp=email )
Change subject: mb/starlabs/starbook: Only show Hyper-Threading option when relevant ......................................................................
mb/starlabs/starbook: Only show Hyper-Threading option when relevant
Guard the Hyper-Threading option against SOC_INTEL_ALDERLAKE_PCH_N, as the N200 processors used don't support it.
Change-Id: Ia30a14bd652bf8f2abad5fb5c19aed1cad694929 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/86166 Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/starlabs/starbook/cfr.c 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/starlabs/starbook/cfr.c b/src/mainboard/starlabs/starbook/cfr.c index 9efe924..7316f2a 100644 --- a/src/mainboard/starlabs/starbook/cfr.c +++ b/src/mainboard/starlabs/starbook/cfr.c @@ -97,12 +97,14 @@ }); #endif
+#if !CONFIG(SOC_INTEL_ALDERLAKE_PCH_N) static const struct sm_object hyper_threading = SM_DECLARE_BOOL({ .opt_name = "hyper_threading", .ui_name = "Hyper-Threading", .ui_helptext = "Enable or disable Hyper-Threading", .default_value = true, }); +#endif
static const struct sm_object kbl_timeout = SM_DECLARE_ENUM({ .opt_name = "kbl_timeout", @@ -291,7 +293,9 @@ .obj_list = (const struct sm_object *[]) { &me_state, &me_state_counter, + #if !CONFIG(SOC_INTEL_ALDERLAKE_PCH_N) &hyper_threading, + #endif &vtd, NULL },