[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8183: Init SPM driver

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34545 )

Change subject: mediatek/mt8183: Init SPM driver
......................................................................

Patch Set 3:

(4 comments)

https://review.coreboot.org/c/coreboot/+/34545/3/src/soc/mediatek/mt8183/spm... 
File src/soc/mediatek/mt8183/spm.c:

https://review.coreboot.org/c/coreboot/+/34545/3/src/soc/mediatek/mt8183/spm... 
PS3, Line 93: 	if (!wait_us(SPM_CORE_TIMEOUT,
suspect code indent for conditional statements (8, 28)

https://review.coreboot.org/c/coreboot/+/34545/3/src/soc/mediatek/mt8183/spm... 
PS3, Line 110: 	if ((read32(&mtk_spm->pcm_reg1_data) == 0x1) &&
suspect code indent for conditional statements (8, 14)

https://review.coreboot.org/c/coreboot/+/34545/3/src/soc/mediatek/mt8183/spm... 
PS3, Line 278: 	        __LINE__, dyna_load_pcm_path[index]);
code indent should use tabs where possible

https://review.coreboot.org/c/coreboot/+/34545/3/src/soc/mediatek/mt8183/spm... 
PS3, Line 297: 	while ((read32(&mtk_spm->pcm_fsm_sta) & (0x7 << 7)) != (0x4 << 7))
suspect code indent for conditional statements (8, 15)