Attention is currently required from: Tarun Tuli.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74233 )
Change subject: mb/google/brya: Compile gpio.c in SMM ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/brask/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/74233/comment/25751c66_9e54f7d0 PS1, Line 9: smm-y += gpio.c
would it make sense to make this conditional on the config option?
potentially. I'm not sure why it was done unconditionally on previous boards, since SMMSTORE support wasn't really a consideration when adding the board. I don't have any problem with making it conditional here