Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33738 )
Change subject: device/Kconfig: Add HAVE_EXT_GFX kconfig
......................................................................
Patch Set 7: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/33738/6/src/device/Kconfig
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/33738/6/src/device/Kconfig@133
PS6, Line 133: graphics card and selecting this Kconfig will ask FSP to make IGD disable.
This is not the case in the current patch or one of the following.
Also I don't see any reason why you want to disable the onboard IGD.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33738
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ebde69e38defbe3321eb5e5bbd632c209ae2cd8
Gerrit-Change-Number: 33738
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 08 Jul 2019 10:28:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment