Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, SH Kim.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80327?usp=email )
Change subject: mb/google/brya/var/xol: Update Kconfig
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/80327/comment/86043992_fd4d504f :
PS2, Line 481: select DRIVERS_INTEL_ISH
this is with UFS sku I assume ?
https://review.coreboot.org/c/coreboot/+/80327/comment/d75f8cfa_c5677da6 :
PS2, Line 480: select DRIVERS_I2C_DA7219
: select DRIVERS_INTEL_ISH
please follow the alphabetic order
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80327?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7e896eb01d37f06a6f1f956d6cd2c2263fefd781
Gerrit-Change-Number: 80327
Gerrit-PatchSet: 2
Gerrit-Owner: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 02 Feb 2024 04:28:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment