[coreboot-gerrit] Change in coreboot[master]: nb/intel/ironlake/raminit.c: initialize 'reply.command'

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42461 )

Change subject: nb/intel/ironlake/raminit.c: initialize 'reply.command'
......................................................................

nb/intel/ironlake/raminit.c: initialize 'reply.command'

This to silent a bug found using gcc-10.
src/northbridge/intel/ironlake/raminit.c: In function 'setup_heci_uma':
src/northbridge/intel/ironlake/raminit.c:1805:11: error: 'reply.command' may be used uninitialized in this function [-Werror=maybe-uninitialized]
 1805 |  if (reply.command != (MKHI_SET_UMA | (1 << 7)))
      |      ~~~~~^~~~~~~~
cc1: all warnings being treated as errors

Change-Id: I0d13de549b6d428ac3675ee3f91eb5e42aeb25e8
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42461
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/northbridge/intel/ironlake/raminit.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/northbridge/intel/ironlake/raminit.c b/src/northbridge/intel/ironlake/raminit.c
index f1f8aa5..f50adb1 100644
--- a/src/northbridge/intel/ironlake/raminit.c
+++ b/src/northbridge/intel/ironlake/raminit.c
@@ -1782,6 +1782,10 @@
    	u8 field2;
    	u8 unk3[0x48 - 4 - 1];
    } __packed reply;
+
+	/* FIXME: recv_heci_message() does not always initialize 'reply' */
+	reply.command = 0;
+
    struct uma_message {
    	u8 group_id;
    	u8 cmd;