Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45562 )
Change subject: nb/intel/ironlake: Add more host bridge PCI IDs ......................................................................
Patch Set 4:
(2 comments)
Patch Set 4:
(1 comment)
What's the public names of Clarkdale? Or which spec-update do I have to read to review this?
[0x40] Refer to the Clarkdale spec update: https://web.archive.org/web/20200418060904if_/https://www.intel.com/content/...
[0x44] Already present in the code, but refer to the Arrandale spec update: https://cdrdv2.intel.com/v1/dl/getContent/600249
[0x48] Download Intel chipset drivers for Windows, e.g. these: http://dl.drp.su/driverpacks/repack/Chipset/Intel/WinAll/Chipset/9.3.2.1020_... Open `IntelCP2.inf` and look for `0048`. Also see line 1523 of: https://raw.githubusercontent.com/coreboot/coreboot/f2c32515ee9a4f4db46ee512... Also see: https://pci-ids.ucw.cz/read/PC/8086/0048 Also see: https://lists.debian.org/debian-boot/2010/10/msg00567.html The last link indicates this PCI DID can be found on at least Clarkdale stepping C-2. However, it is not known whether the
[0x62] Refer to: https://github.com/torvalds/linux/blob/master/drivers/char/agp/intel-agp.h#L... Dig through commit history to find: https://github.com/torvalds/linux/commit/07fb6111e7af5fac6b6076e2658d0e32b67... Looks like this is a mobile variant, but I've tagged it as Clarkdale. I will fix. Stepping unknown.
[0x69] Refer to first link in [0x62], view blame for the "0x69" DID, which links to this commit: https://github.com/torvalds/linux/commit/67384fe3fd450536342330f684ea1f7dcae... Commit links to this bug report: https://bugs.freedesktop.org/show_bug.cgi?id=50381 View attachment 62133: https://bugs.freedesktop.org/attachment.cgi?id=62133 Grep for `CPU0`, second match is: [ 0.044673] CPU0: Intel(R) Core(TM) i3 CPU 540 @ 3.07GHz stepping 05 Refer to the Clarkdale spec update from [0x40] to identify this as Clarkdale stepping K-0.
[0x6a] This is the PCI DID which came up twice, and which this patch attempts to take care of. Refer to first link in [0x62] for another source of this ID. Refer to one of the CBMEM logs where this PCI DID showed up in: http://kurisu.sakamoto.pl/~milesedgeworth/cbmem.log Look for the part where microcode is updated, which contains the CPU model name and CPUID: microcode: sig=0x20655 pf=0x10 revision=0x7 CPU: Intel(R) Core(TM) i7 CPU L 640 @ 2.13GHz. Refer to the Arrandale spec update from [0x44] to identify this as Arrandale stepping K-0. Also see: https://github.com/torvalds/linux/commit/9eecabcb9a924f1e11ba670365fd4babe42...
https://review.coreboot.org/c/coreboot/+/45562/4/src/northbridge/intel/ironl... File src/northbridge/intel/ironlake/northbridge.c:
https://review.coreboot.org/c/coreboot/+/45562/4/src/northbridge/intel/ironl... PS4, Line 223: Clarkdale Arrandale.
https://review.coreboot.org/c/coreboot/+/45562/4/src/northbridge/intel/ironl... PS4, Line 252: CHIP_NAME("Intel i7 (Arrandale) integrated Northbridge")
Needs an update, I guess.
Indeed, not everyone has an i7.