build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43408 )
Change subject: soc/amd/picasso: add dptc support ......................................................................
Patch Set 14:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43408/14/src/soc/amd/picasso/includ... File src/soc/amd/picasso/include/soc/dptc.h:
https://review.coreboot.org/c/coreboot/+/43408/14/src/soc/amd/picasso/includ... PS14, Line 17: #endif /* __PICASSO_DPTC_H__ */ adding a line without newline at end of file
https://review.coreboot.org/c/coreboot/+/43408/14/src/soc/amd/picasso/root_c... File src/soc/amd/picasso/root_complex.c:
https://review.coreboot.org/c/coreboot/+/43408/14/src/soc/amd/picasso/root_c... PS14, Line 153: acpigen_emit_namestring("SSZE");; Statements terminations use 1 semicolon
https://review.coreboot.org/c/coreboot/+/43408/14/src/soc/amd/picasso/root_c... PS14, Line 207: dptci_update_parameter(DPTC_SUSTAINED_POWER_LIMIT, config->dptc_sustained_power_limit); line over 96 characters
https://review.coreboot.org/c/coreboot/+/43408/14/src/soc/amd/picasso/root_c... PS14, Line 214: dptci_update_parameter(DPTC_SUSTAINED_POWER_LIMIT, config->sustained_power_limit); line over 96 characters