Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39459 )
Change subject: soc/intel/tigerlake: Configure IOM_TYPEC_SW_CONFIGURATUON_3 ......................................................................
Patch Set 3:
(6 comments)
https://review.coreboot.org/c/coreboot/+/39459/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39459/3//COMMIT_MSG@16 PS3, Line 16: setting and what each bit represents Please add a dot/period at the end of sentences.
https://review.coreboot.org/c/coreboot/+/39459/3//COMMIT_MSG@23 PS3, Line 23: orientation. On what board?
https://review.coreboot.org/c/coreboot/+/39459/3/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/39459/3/src/soc/intel/tigerlake/chi... PS3, Line 237: * this is a bitfield that corresponds to up to 5 TCSS ports Dot/period or colon at the end.
https://review.coreboot.org/c/coreboot/+/39459/3/src/soc/intel/tigerlake/chi... PS3, Line 237: this This …
https://review.coreboot.org/c/coreboot/+/39459/3/src/soc/intel/tigerlake/chi... PS3, Line 241: * of the physical aux lines on the motherboard Format the items as a list?
https://review.coreboot.org/c/coreboot/+/39459/3/src/soc/intel/tigerlake/chi... PS3, Line 242: */ New textwidth is 96 characters.