[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Add GPIO PM override configuration into NVS

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37793 )

Change subject: soc/intel/common: Add GPIO PM override configuration into NVS
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37793/3/src/soc/intel/common/block/... 
File src/soc/intel/common/block/acpi/acpi/globalnvs.asl:

https://review.coreboot.org/c/coreboot/+/37793/3/src/soc/intel/common/block/... 
PS3, Line 50: OGPM
Do we really need this? Can we have a policy that GPIO PM bits are saved before entering lower power state and restored on exit irrespective of what is configured. Then, it doesn't matter what the mainboard configures i.e. even if the override is not set by mainboard, we would still save --> enable all --> restore. This would avoid the need to have a NVS variable.