[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake|soc/intel/common: Add support for UARTs on PCH-H

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40405 )

Change subject: soc/intel/cannonlake|soc/intel/common: Add support for UARTs on PCH-H
......................................................................

Patch Set 14:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40405/9/src/soc/intel/cannonlake/pc... 
File src/soc/intel/cannonlake/pch_h.c:

PS9:
> it evolved into something generic. besides _HID and _CID there's nothing special about it.

Move to common code.

https://review.coreboot.org/c/coreboot/+/40405/9/src/soc/intel/cannonlake/pc... 
PS9, Line 66: ",
> That would be hard. For ACPI mode, the hardcoded _ADR should be removed. […]

Added detection for ACPI mode and only emmit the _HID when running in such.