Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34397 )
Change subject: mb/google/kohaku: Update DPTF parameters and TDP PL1/PL2 ......................................................................
Patch Set 4:
(2 comments)
It’s quite hard to review this change. The commit message should be more elaborate.
https://review.coreboot.org/c/coreboot/+/34397/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34397/4//COMMIT_MSG@11 PS4, Line 11: The main purpose of this change is adjusting PL1 and PL2, : and we need further fine tuning later. Please use the full textwidth.
https://review.coreboot.org/c/coreboot/+/34397/4//COMMIT_MSG@9 PS4, Line 9: Update DPTF parameters and TDP PL1/PL2 values for kohaku. : : The main purpose of this change is adjusting PL1 and PL2, : and we need further fine tuning later. What are you achieving with the update?
Adjust PL1 and PL2 to …. More fine-tuning will happen later.