Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35040 )
Change subject: soc/intel/common/block: Provide mmc.c for setting dll registers.
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35040/5/src/soc/intel/common/block/...
File src/soc/intel/common/block/scs/mmc.c:
https://review.coreboot.org/c/coreboot/+/35040/5/src/soc/intel/common/block/...
PS5, Line 61: SOC_INTEL_COMMON_MMC_OVERRIDE
Hi Furquan, […]
Actually, I wanted to see if we can avoid configuring the UPDs completely for eMMC? If coreboot can take care of configuring the values, do we still need to set FSP UPDs at all?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35040
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3c72b9851f41585ec099d8ae83a721af87ed383
Gerrit-Change-Number: 35040
Gerrit-PatchSet: 8
Gerrit-Owner: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 27 Aug 2019 01:48:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kane Chen
kane.chen@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment