Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31352 )
Change subject: soc/intel/apl: Implement "Power State after Failure"
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/31352/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31352/2//COMMIT_MSG@8
PS2, Line 8:
Could you elaborate please?
https://review.coreboot.org/#/c/31352/2/src/soc/intel/common/block/fast_spi/...
File src/soc/intel/common/block/fast_spi/Makefile.inc:
https://review.coreboot.org/#/c/31352/2/src/soc/intel/common/block/fast_spi/...
PS2, Line 17: ifeq ($(CONFIG_SPI_FLASH_SMM),y)
How is this related?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31352
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf218b90088a45349c54f4b881e895bb852e88bb
Gerrit-Change-Number: 31352
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 12 Feb 2019 12:04:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment