Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44588 )
Change subject: mb/google/dedede/var/boten: Add LTE power on/off sequence ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44588/7/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/gpio.c:
https://review.coreboot.org/c/coreboot/+/44588/7/src/mainboard/google/dedede... PS7, Line 39: PAD_CFG_GPO(GPP_H17, 1, PLTRST), Do we make sure the nature boot time from bootblock to ramstage here is larger than 20ms?
https://review.coreboot.org/c/coreboot/+/44588/7/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/variant.c:
https://review.coreboot.org/c/coreboot/+/44588/7/src/mainboard/google/dedede... PS7, Line 35: saving one transaction to the EC for getting SKU ID. Looks like the checking of SKU ID for LTE functionality is not added yet.