Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35946 )
Change subject: pciexp: Add support for allocating PCI express hotplug resources
......................................................................
Patch Set 4:
(3 comments)
I addressed some of the comments in patch set 4. I am working on a variety of GPUs and expect to have further updates as necessary.
https://review.coreboot.org/c/coreboot/+/35946/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35946/3//COMMIT_MSG@27
PS3, Line 27: assign-buses
It should be "assign-busses", as Documentation/x86/x86_64/boot-options.rst of Linux kernel states.
Done
https://review.coreboot.org/c/coreboot/+/35946/3/src/device/Kconfig
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/35946/3/src/device/Kconfig@576
PS3, Line 576: PCIEXP_HOTPLUG_MEM
this should probably be PCIEXP_HOTPLUG_PREFETCH_MEM
Done
https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pciexp_device.c
File src/device/pciexp_device.c:
https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pciexp_device.c@...
PS2, Line 488: resource->gran = 22;
I'm not sure this needs to be anything other than page aligned. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35946
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I500191626584b83e6a8ae38417fd324b5e803afc
Gerrit-Change-Number: 35946
Gerrit-PatchSet: 4
Gerrit-Owner: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Bill XIE
persmule@hardenedlinux.org
Gerrit-CC: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-CC: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Mimoja
coreboot@mimoja.de
Gerrit-CC: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Mon, 13 Jan 2020 18:14:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Jeremy Soller
jeremy@system76.com
Comment-In-Reply-To: Bill XIE
persmule@hardenedlinux.org
Gerrit-MessageType: comment