13 Oct
2020
13 Oct
'20
9:57 a.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46144 )
Change subject: drivers/i2c/gpiomux: Add chip driver for multiplexed I2C bus ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46144/2/src/drivers/i2c/gpiomux/bus... File src/drivers/i2c/gpiomux/bus/bus.c:
https://review.coreboot.org/c/coreboot/+/46144/2/src/drivers/i2c/gpiomux/bus... PS2, Line 20: malloc Just curious: You used a static buffer in earlier CL, but malloc here. Why the difference in choice?
--
To view, visit https://review.coreboot.org/c/coreboot/+/46144
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If8b983bc8ce212ce05fe6b7f01a6d9092468e582
Gerrit-Change-Number: 46144
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 13 Oct 2020 06:57:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment