Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42468 )
Change subject: drivers/intel/mipi_camera: SSDT changes to add DSM ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42468/2/src/drivers/intel/mipi_came... File src/drivers/intel/mipi_camera/camera.c:
https://review.coreboot.org/c/coreboot/+/42468/2/src/drivers/intel/mipi_came... PS2, Line 19: 0xFFFF if this is chosen, do you still want to return a valid address? or should you return 0?
https://review.coreboot.org/c/coreboot/+/42468/2/src/drivers/intel/mipi_came... PS2, Line 40: int local1_ret = (config->ssdb.vcm_type ? 1 : 0) + (config->ssdb.rom_type ? 1 : 0) + 1; nit: the '+ 1' gets a little lost at the end, maybe put it first? 1 + .... + .... ?