Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34333 )
Change subject: src/arch/x86/acpi.c: Change TPM2 ACPI Table to support CRB
......................................................................
Patch Set 22:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34333/22//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34333/22//COMMIT_MSG@7
PS22, Line 7: src/arch/x86/acpi.c: Change TPM2 ACPI Table to support CRB
Please remove `src`.
https://review.coreboot.org/c/coreboot/+/34333/22//COMMIT_MSG@7
PS22, Line 7: Change
Redundant, as a commit often changes something.
arch/x86/acpi: Hook up TPM2 CRB
https://review.coreboot.org/c/coreboot/+/34333/22//COMMIT_MSG@10
PS22, Line 10: selected.
Sentence should fit on one line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34333
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide3af348fd4676f2d04e1d0b9ad83f9124e09dcc
Gerrit-Change-Number: 34333
Gerrit-PatchSet: 22
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lance Zhao
lance.zhao@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jul 2019 13:06:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment