Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86029?usp=email )
Change subject: commonlib/dt: Fix recursive call for _dt_find_node ......................................................................
commonlib/dt: Fix recursive call for _dt_find_node
Correctly call _dt_find_node recursively to avoid incorrect re-initialization of addrcp and sizecp.
BUG=none TEST=Test coverage can pass.
Change-Id: Icad075485f0a8a22138f1a0e1885405749ae5253 Signed-off-by: Kapil Porwal kapilporwal@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/86029 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org Reviewed-by: Subrata Banik subratabanik@google.com --- M src/commonlib/device_tree.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Julius Werner: Looks good to me, approved Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/commonlib/device_tree.c b/src/commonlib/device_tree.c index a7007d9..4d72fb0 100644 --- a/src/commonlib/device_tree.c +++ b/src/commonlib/device_tree.c @@ -1074,7 +1074,7 @@ list_insert_after(&found->list_node, &parent->children); }
- return dt_find_node(found, path + 1, addrcp, sizecp, create); + return _dt_find_node(found, path + 1, addrcp, sizecp, create); }
/*