Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40567 )
Change subject: mb/google/deltaur: Move early gpio table to variants
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40567/3/src/mainboard/google/deltau...
File src/mainboard/google/deltaur/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/40567/3/src/mainboard/google/deltau...
PS3, Line 410: early_gpio_table
Is the table used in deltaur and deltan exactly the same? If yes, then you don't need to drop this from the baseboard/gpio.c. Just remove the variant_early_gpio_table() implementation in deltaur and deltan.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40567
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4c4648ccf918446a499019a4f77f64e43a92c76
Gerrit-Change-Number: 40567
Gerrit-PatchSet: 3
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 21 Apr 2020 17:45:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment