Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37483 )
Change subject: mb/gigabyte/ga-h61m-s2pv: Add ga-h61m-ds2v as a variant ......................................................................
Patch Set 4: Code-Review+2
(2 comments)
Feel free to fill the commit message with what was tested.
https://review.coreboot.org/c/coreboot/+/37483/4/src/mainboard/gigabyte/ga-h... File src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/37483/4/src/mainboard/gigabyte/ga-h... PS4, Line 10: select NO_UART_ON_SUPERIO I don't think this belongs into Kconfig.name; but don't know any hard rules about it either.
https://review.coreboot.org/c/coreboot/+/37483/1/src/mainboard/gigabyte/ga-h... File src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-ds2v/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37483/1/src/mainboard/gigabyte/ga-h... PS1, Line 58: device pci 1c.7 off end # Unused PCIe Port
These don't exist on H61, so they won't ever be enabled I guess
TIL