Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38549 )
Change subject: mainboard/ocp: Add support for OCP platform TiogaPass ......................................................................
Patch Set 14:
(7 comments)
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/Kconfig:
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas... PS14, Line 34: OCP Vendor shouldn't be needed here
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas... PS14, Line 34: TiogaPass Is it TiogaPass or Tioga Pass?
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas... PS14, Line 39: : config MAINBOARD_VENDOR : string : default "OCP" Set to "Open Compute Project" in src/mb/ocp/Kconfig
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas... PS14, Line 25: CPPFLAGS_common += -I$(src)/soc/intel/skylake_sp/include This should not be here
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas... PS14, Line 27: : /* Disable USB ports in S5 */ : gnvs->s5u0 = 0; : gnvs->s5u1 = 0; These can be dropped
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas... PS14, Line 32: Present Really?
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas... File src/mainboard/ocp/tiogapass/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas... PS14, Line 62: device pci 04.0 on end # Intel Corporation Sky Lake-E CBDMA Registers These comments can be shortened