build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: mb/google/asurada: Add anx7625 panel driver
......................................................................
Patch Set 20:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46575/20/src/mainboard/google/asura...
File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/20/src/mainboard/google/asura...
PS20, Line 32: #define INIT_DCS_CMD(...) \
Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/20/src/mainboard/google/asura...
PS20, Line 37: #define INIT_GENERIC_CMD(...) \
Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/20/src/mainboard/google/asura...
PS20, Line 42: #define INIT_DELAY_CMD(delay) \
Macros with complex values should be enclosed in parentheses
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46575
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I045d2042b5649e36470500f266f108564b7063fa
Gerrit-Change-Number: 46575
Gerrit-PatchSet: 20
Gerrit-Owner: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-Reviewer: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Huijuan Xie
huijuan.xie@mediatek.corp-partner.google.com
Gerrit-Reviewer: Jg Daolongzhu
jg_daolongzhu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yidi Lin
yidi.lin@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Wed, 09 Dec 2020 02:55:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment