Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44930 )
Change subject: security/intel/txt/Kconfig: Drop redundant 'select ENABLE_VMX' ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44930/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44930/1//COMMIT_MSG@7 PS1, Line 7: redundant It is not redundant. TXT *requires* VMX to be enabled. The current approach will make sure ENABLE_VMX is selected when TXT support is enabled.
Sure, a `depends on` would also work, but it would instead hide TXT support unless ENABLE_VMX is selected, which is not user-friendly.