build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39174 )
Change subject: lz4: Fix out-of-bounds reads ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39174/1/util/cbfstool/lz4/lib/lz4.c File util/cbfstool/lz4/lib/lz4.c:
https://review.coreboot.org/c/coreboot/+/39174/1/util/cbfstool/lz4/lib/lz4.c... PS1, Line 1209: if ((endOnInput) && unlikely(ip>=iend-RUN_MASK)) goto _output_error; /* overflow detection */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/39174/1/util/cbfstool/lz4/lib/lz4.c... PS1, Line 1209: if ((endOnInput) && unlikely(ip>=iend-RUN_MASK)) goto _output_error; /* overflow detection */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39174/1/util/cbfstool/lz4/lib/lz4.c... PS1, Line 1209: if ((endOnInput) && unlikely(ip>=iend-RUN_MASK)) goto _output_error; /* overflow detection */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39174/1/util/cbfstool/lz4/lib/lz4.c... PS1, Line 1209: if ((endOnInput) && unlikely(ip>=iend-RUN_MASK)) goto _output_error; /* overflow detection */ spaces required around that '>=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39174/1/util/cbfstool/lz4/lib/lz4.c... PS1, Line 1209: if ((endOnInput) && unlikely(ip>=iend-RUN_MASK)) goto _output_error; /* overflow detection */ trailing statements should be on next line