Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42064 )
Change subject: soc/amd/picasso: Allow modification of i2c base addresses in PSP ......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42064/5/src/soc/amd/picasso/i2c-x86... File src/soc/amd/picasso/i2c-x86.c:
https://review.coreboot.org/c/coreboot/+/42064/5/src/soc/amd/picasso/i2c-x86... PS5, Line 19: _Static_assert( : ARRAY_SIZE(i2c_bus_address) == I2C_MASTER_DEV_COUNT + I2C_SLAVE_DEV_COUNT, : "ARRAY_SIZE(i2c_bus_address) must equal I2C_MASTER_DEV_COUNT + I2C_SLAVE_DEV_COUNT");
fixing in follow-on patch
Ack
https://review.coreboot.org/c/coreboot/+/42064/14/src/soc/amd/picasso/i2c.c File src/soc/amd/picasso/i2c.c:
https://review.coreboot.org/c/coreboot/+/42064/14/src/soc/amd/picasso/i2c.c@... PS14, Line 28: APU_I2C2_BASE For ARM, this will have x86 addresses by default. I think Kyösti wanted to make sure there were no x86 addresses in the PSP.
https://review.coreboot.org/c/coreboot/+/42064/14/src/soc/amd/picasso/i2c.c@... PS14, Line 71: APU_I2C2_BASE Think that also includes these.