Attention is currently required from: Angel Pons, Werner Zeh.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70468 )
Change subject: drivers/intel/i210/Makefile.inc: Remove a link path to itself ......................................................................
Patch Set 13:
(1 comment)
Patchset:
PS8:
sure!
Please let make some progress. Is this ok for you?: ``` diff --git a/src/drivers/intel/i210/Makefile.inc b/src/drivers/intel/i210/Makefile.inc index 218b1b45f9..e599798f9b 100644 --- a/src/drivers/intel/i210/Makefile.inc +++ b/src/drivers/intel/i210/Makefile.inc @@ -1,7 +1,3 @@ ## SPDX-License-Identifier: GPL-2.0-only
ramstage-$(CONFIG_DRIVER_INTEL_I210)+= i210.c - -ifeq ($(CONFIG_DRIVER_INTEL_I210),y) -CFLAGS_x86_32 += -Isrc/drivers/intel/i210 -endif diff --git a/src/mainboard/siemens/mc_apl1/Makefile.inc b/src/mainboard/siemens/mc_apl1/Makefile.inc index fa7aea9049..84675e45c1 100644 --- a/src/mainboard/siemens/mc_apl1/Makefile.inc +++ b/src/mainboard/siemens/mc_apl1/Makefile.inc @@ -10,4 +10,8 @@ ramstage-y += mainboard.c subdirs-y += variants/baseboard CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include
+ifeq ($(CONFIG_DRIVER_INTEL_I210),y) +CPPFLAGS_common += -I$(src)/drivers/intel/i210 +endif + subdirs-y += variants/$(VARIANT_DIR) diff --git a/src/mainboard/siemens/mc_ehl/Makefile.inc b/src/mainboard/siemens/mc_ehl/Makefile.inc index e34eddb9f1..525961e72e 100644 --- a/src/mainboard/siemens/mc_ehl/Makefile.inc +++ b/src/mainboard/siemens/mc_ehl/Makefile.inc @@ -11,4 +11,8 @@ ramstage-y += mainboard.c subdirs-y += variants/baseboard CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include
+ifeq ($(CONFIG_DRIVER_INTEL_I210),y) +CPPFLAGS_common += -I$(src)/drivers/intel/i210 +endif + subdirs-y += variants/$(VARIANT_DIR) ```