[coreboot-gerrit] [L] Change in coreboot[main]: mb/hp: Add Elitebook 8560w as an HP Sandy/Ivy Bridge laptop variant

[Iru Cai (Code Review)]

Attention is currently required from: Angel Pons, Riku Viitanen.

Iru Cai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39398?usp=email )

Change subject: mb/hp: Add Elitebook 8560w as an HP Sandy/Ivy Bridge laptop variant
......................................................................

Patch Set 4:

(9 comments)

Patchset:

PS3:
> I have an 8560w now too. […]

Hmm, I haven't read the debug log, but I can see the boot time is longer than the vendor firmware. I use an NVIDIA card.

Patchset:

PS4: 
Update on the current coreboot code. It still boots, but I haven't tested the components yet.

File Documentation/mainboard/hp/8560w.md:

https://review.coreboot.org/c/coreboot/+/39398/comment/379bff41_0896560b :
PS1, Line 12: 8MB
> 8 MiB

Done

File Documentation/mainboard/hp/8560w.md:

https://review.coreboot.org/c/coreboot/+/39398/comment/2c5e3ba2_f840b5f5 :
PS2, Line 10: ## Flashing instructions
> flashrom output on vendor BIOS: https://termbin.com/gzaq6 […]

I haven't tried flashing on vendor firmware yet.

File src/mainboard/hp/snb_ivb_laptops/variants/8560w/board_info.txt:

https://review.coreboot.org/c/coreboot/+/39398/comment/17f5daea_66e9b1a2 :
PS2, Line 6: n
> huh?

Done

File src/mainboard/hp/snb_ivb_laptops/variants/8560w/early_init.c:

https://review.coreboot.org/c/coreboot/+/39398/comment/2acba906_841dc62d :
PS1, Line 1: /*
           :  * This file is part of the coreboot project.
           :  *
           :  * Copyright 2020 The coreboot project Authors.
           :  *
           :  * SPDX-License-Identifier: GPL-2.0-or-later
           :  */
> /* SPDX-License-Identifier: GPL-2. […]

Done

File src/mainboard/hp/snb_ivb_laptops/variants/8560w/gpio.c:

https://review.coreboot.org/c/coreboot/+/39398/comment/e09e41e9_a73dc33b :
PS1, Line 1: /*
           :  * This file is part of the coreboot project.
           :  *
           :  * Copyright 2020 The coreboot project Authors.
           :  *
           :  * SPDX-License-Identifier: GPL-2.0-or-later
           :  */
> /* SPDX-License-Identifier: GPL-2. […]

Done

File src/mainboard/hp/snb_ivb_laptops/variants/8560w/hda_verb.c:

https://review.coreboot.org/c/coreboot/+/39398/comment/84e0ba5a_3e52272d :
PS1, Line 1: /*
           :  * This file is part of the coreboot project.
           :  *
           :  * Copyright 2020 The coreboot project Authors.
           :  *
           :  * SPDX-License-Identifier: GPL-2.0-or-later
           :  */
> /* SPDX-License-Identifier: GPL-2. […]

Done

File src/mainboard/hp/snb_ivb_laptops/variants/8560w/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/39398/comment/f8857902_5f321d37 :
PS1, Line 26: end
> nit: align the `end` words?

Done