Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45448 )
Change subject: nb/intel/gm45: Add more DMIBAR/EPBAR registers ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45448/3/src/northbridge/intel/gm45/... File src/northbridge/intel/gm45/pcie.c:
https://review.coreboot.org/c/coreboot/+/45448/3/src/northbridge/intel/gm45/... PS3, Line 42: ;
I've decided to spend as little effort as possible on cosmetics, especially if there's any form of d […]
Sorry, I might have used the wrong words here and hidden the value of such discussions this way. Sure, sometimes discussions about cosmetics are merely about somebody's personal taste and a waste of time. But sometimes such a discussion can help us to become better developers, IMHO, or even result in better style guidelines. Anyway, let's not turn this into a meta-discussion :)