6 May
2022
6 May
'22
2:46 a.m.
Attention is currently required from: Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64089 )
Change subject: intelblocks: Add function to enable GPE ......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/64089/comment/e50a91b8_65f7879b PS2, Line 379: gpi_enable_smi(cfg, comm);
My idea is config all DW0 in one time. Just add up all the BITs. […]
oh, sorry. Those not in the DW0. In the case probably we can use the static to store them and write in one time?
--
To view, visit https://review.coreboot.org/c/coreboot/+/64089
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27e525f50c374c2cc9675e77eaa7774683a6e7c2
Gerrit-Change-Number: 64089
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 06 May 2022 08:46:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maulik V Vaghela maulik.v.vaghela@intel.com
Comment-In-Reply-To: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment