Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39530 )
Change subject: soc/intel/Kconfig: Avoid specify dedicated chipset name
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39530/1/src/soc/intel/Kconfig
File src/soc/intel/Kconfig:
https://review.coreboot.org/c/coreboot/+/39530/1/src/soc/intel/Kconfig@a15
PS1, Line 15: source "src/soc/intel/common/Kconfig"
IIRC, it was done this way because we want SoC specific Kconfigs to be sourced before common Kconfig since the config system picks up the first value that it encounters for a Kconfig variable.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39530
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2d8a8ac1c4acfabd4ded1bfd4ff359e820e174b
Gerrit-Change-Number: 39530
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 14 Mar 2020 08:21:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment