[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Configure GPIO PM configuration in bootblock

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37319 )

Change subject: soc/intel/cannonlake: Configure GPIO PM configuration in bootblock
......................................................................

Patch Set 10:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37319/8//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37319/8//COMMIT_MSG@11 
PS8, Line 11: 2. Avoid redundent definitions of soc_fill_gpio_pm_configuration
> nit: This wasn't really true before the change was made. :). […]

Done

https://review.coreboot.org/c/coreboot/+/37319/8/src/soc/intel/cannonlake/in... 
File src/soc/intel/cannonlake/include/soc/gpio.h:

https://review.coreboot.org/c/coreboot/+/37319/8/src/soc/intel/cannonlake/in... 
PS8, Line 33: rotine
> nit: routine

Done