Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46406 )
Change subject: mb/google/asurada: Implement board-specific regulator controls ......................................................................
Patch Set 11:
(7 comments)
https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... File src/mainboard/google/asurada/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 16: romstage-y += regulator.c Please sort these alphabetically (except memlayout.ld).
https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... File src/mainboard/google/asurada/regulator.c:
https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 8: mt6360_regulator_id Should we put it in soc/mediatek/mt8192/include/soc/mt6360.h?
https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 15: Extra blank line
https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 51: underly underlying
https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 50: /* Handle the regulator which does not have a regulator ID : * in its underly implementation. */ Please choose one of the following formats:
/* Handle the regulator which does not have a regulator ID in its underly implementation. */
/* * Handle the regulator which does not have a regulator ID * in its underly implementation. */
https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 78: underly underlying
https://review.coreboot.org/c/coreboot/+/46406/11/src/mainboard/google/asura... PS11, Line 77: /* Handle the regulator which does not have a regulator ID : * in its underly implementation. */ Same