Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52895 )
Change subject: include/console: Fix duplicate entry of postcode 0x79 ......................................................................
include/console: Fix duplicate entry of postcode 0x79
Change POST_PRE_HARDWAREMAIN postcode value from 0x79 to 0x6e to avoid duplicate entry.
Change-Id: I50cc75cd3097fba3e7faff05188511bba69ef1e7 Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/52895 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/arch/x86/c_start.S M src/include/console/post_codes.h 2 files changed, 8 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Marshall Dawson: Looks good to me, approved
diff --git a/src/arch/x86/c_start.S b/src/arch/x86/c_start.S index 19532d8..f55ab6e 100644 --- a/src/arch/x86/c_start.S +++ b/src/arch/x86/c_start.S @@ -89,7 +89,7 @@ * bss is cleared. Now we call the main routine and * let it do the rest. */ - post_code(POST_PRE_HARDWAREMAIN) /* post fe */ + post_code(POST_PRE_HARDWAREMAIN) /* post 6e */
andl $0xFFFFFFF0, %esp
diff --git a/src/include/console/post_codes.h b/src/include/console/post_codes.h index 677cd36..9682e4d 100644 --- a/src/include/console/post_codes.h +++ b/src/include/console/post_codes.h @@ -105,6 +105,13 @@ #define POST_ENABLING_CACHE 0x60
/** + * \brief Pre call to RAM stage main() + * + * POSTed right before RAM stage main() is called from c_start.S + */ +#define POST_PRE_HARDWAREMAIN 0x6e + +/** * \brief Before Device Probe * * Boot State Machine: bs_pre_device() @@ -175,13 +182,6 @@ #define POST_BS_WRITE_TABLES 0x79
/** - * \brief Pre call to RAM stage main() - * - * POSTed right before RAM stage main() is called from c_start.S - */ -#define POST_PRE_HARDWAREMAIN 0x79 - -/** * \brief Load Payload * * Boot State Machine: bs_payload_load()