build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43612 )
Change subject: ec/system76_ec: Add support for System76 EC ......................................................................
Patch Set 4:
(9 comments)
https://review.coreboot.org/c/coreboot/+/43612/4/src/ec/system76/ec/system76... File src/ec/system76/ec/system76_ec.c:
https://review.coreboot.org/c/coreboot/+/43612/4/src/ec/system76/ec/system76... PS4, Line 22: for (int i = 0; i < 256; i++) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/43612/4/src/ec/system76/ec/system76... PS4, Line 35: for (timeout = 10000; timeout > 0; timeout--) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/43612/4/src/ec/system76/ec/system76... PS4, Line 37: if (system76_ec_read(0) == 0) break; trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/43612/4/src/ec/system76/ec/system76... PS4, Line 55: if (byte == '\n' || len >= 128) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/43612/4/src/include/console/system7... File src/include/console/system76_ec.h:
https://review.coreboot.org/c/coreboot/+/43612/4/src/include/console/system7... PS4, Line 16: static inline void __system76_ec_init(void) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/43612/4/src/include/console/system7... PS4, Line 17: system76_ec_init(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/43612/4/src/include/console/system7... PS4, Line 19: static inline void __system76_ec_tx_flush(void) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/43612/4/src/include/console/system7... PS4, Line 20: system76_ec_flush(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/43612/4/src/include/console/system7... PS4, Line 22: static inline void __system76_ec_tx_byte(unsigned char byte) { open brace '{' following function definitions go on the next line