Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37710 )
Change subject: Revert "{northbridge,soc,southbridge}: Don't use both of _ADR and _HID"
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37710/1/src/northbridge/amd/agesa/f...
File src/northbridge/amd/agesa/family14/acpi/northbridge.asl:
https://review.coreboot.org/c/coreboot/+/37710/1/src/northbridge/amd/agesa/f...
PS1, Line 19: /* Name(_HID, EISAID("PNP0A08")) // PCI Express Root Bridge */
Commented code is generally forbidden, IMHO this is enough of argument to say this originally got rubber-stamped.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37710
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7b52b9e8f2f53574849aa3fddfccfa016288179
Gerrit-Change-Number: 37710
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Denis Carikli
GNUtoo@no-log.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 13 Dec 2019 16:31:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment