Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37324 )
Change subject: soc/amd/common: Access ACPIMMIO via proper symbols ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37324/13/src/soc/amd/common/block/a... File src/soc/amd/common/block/acpimmio/mmio_util.c:
https://review.coreboot.org/c/coreboot/+/37324/13/src/soc/amd/common/block/a... PS13, Line 9:
Is the indentation off or is it just gerrit?
Seems off indeed
https://review.coreboot.org/c/coreboot/+/37324/13/src/soc/amd/common/block/i... File src/soc/amd/common/block/include/amdblocks/acpimmio_map.h:
https://review.coreboot.org/c/coreboot/+/37324/13/src/soc/amd/common/block/i... PS13, Line 117: ACPIMMIO_WDT_BANK
Why the rename from BASE to BANK? The term BANK is only used for the GPIO banks.
These are not base addresses