Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42282 )
Change subject: soc/intel/tigerlake: Disable hybrid storage mode in CSE Lite RO boot
......................................................................
Patch Set 16: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/42282/15//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42282/15//COMMIT_MSG@10
PS15, Line 10: a Optane
an
Done
https://review.coreboot.org/c/coreboot/+/42282/15//COMMIT_MSG@10
PS15, Line 10: strap configuration
Please use just one space.
Done
https://review.coreboot.org/c/coreboot/+/42282/15//COMMIT_MSG@14
PS15, Line 14: CSE Lite supports the strap override when running on CSE RW partition,
Please add a blank line above to separate paragraphs visibly.
Done
https://review.coreboot.org/c/coreboot/+/42282/15/src/soc/intel/tigerlake/fs...
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/42282/15/src/soc/intel/tigerlake/fs...
PS15, Line 268: printk(BIOS_DEBUG, "cse_lite: CSE RO boot in recovery mode\n");
Make it level INFO, and mention that hybrid storage mode is disabled?
Done. Thanks for comments!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42282
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5397cfc007069debe3701bf1e38e81bd17a29f0c
Gerrit-Change-Number: 42282
Gerrit-PatchSet: 16
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 03 Jul 2020 07:37:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment