Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30868 )
Change subject: cpu/intel/smm/gen1: Add pineview to the check for alt SMRR MSR's ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/30868/1/src/cpu/intel/smm/gen1/smmrelocate.c File src/cpu/intel/smm/gen1/smmrelocate.c:
https://review.coreboot.org/#/c/30868/1/src/cpu/intel/smm/gen1/smmrelocate.c... PS1, Line 79: /* Both model_6fx and model_1067x SMRR function slightly differently : from the rest. The MSR are at different location from the rest : and need to be explicitly enabled. */ move that comment to cpu_has_alternative_smrr