Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30506 )
Change subject: sb/intel/common: Remove CAR_GLOBAL use
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/30506/7/src/southbridge/intel/common/spi.c
File src/southbridge/intel/common/spi.c:
https://review.coreboot.org/#/c/30506/7/src/southbridge/intel/common/spi.c@7...
PS7, Line 71: static int g_ichspi_lock = 0
I was about enabling it on fsp_broadwell_de (mc_bdx1). […]
Having CAR migration was _the_ reason for forbidden global variables in romstage. Do you user or need this driver in romstage before you have POSTCAR_STAGE=y?
https://review.coreboot.org/c/coreboot/+/29359
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30506
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2c90d264d851ab4abeca07f412d43d088ad96dc
Gerrit-Change-Number: 30506
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Wed, 20 Feb 2019 13:46:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment