3 Dec
2019
3 Dec
'19
6:36 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37432 )
Change subject: mmio: Add clrsetbitsXX() API in place of updateX() ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37432/1/src/include/device/mmio.h File src/include/device/mmio.h:
https://review.coreboot.org/c/coreboot/+/37432/1/src/include/device/mmio.h@1... PS1, Line 123: _le32
... […]
Ack
https://review.coreboot.org/c/coreboot/+/37432/1/src/include/device/mmio.h@1... PS1, Line 190: clrsetbits_le32
Can you change this as well?
It's part of the next patch. I wanted to separate adding the macros and changing existing code.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37432
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4f7b9fdbdf9e8c0174427b4288f79006d56978b
Gerrit-Change-Number: 37432
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 03 Dec 2019 18:36:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org
Gerrit-MessageType: comment