Attention is currently required from: Angel Pons. Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48921 )
Change subject: sb/intel: Introduce SCMI Kconfig options ......................................................................
Patch Set 7:
(3 comments)
File src/southbridge/intel/common/Kconfig.common:
https://review.coreboot.org/c/coreboot/+/48921/comment/f808844c_b550e59a PS5, Line 123: config HAVE_SCMI
Given that CB:41735 adds the relevant code in southbridge/intel/i82371eb, shouldn't these Kconfig op […]
These two are meant for more than just i82371eb. What impact would there be if these options begin in i82371eb and eventually have to move when more Intel southbridges implement this?
https://review.coreboot.org/c/coreboot/+/48921/comment/0b098800_b5cd4524 PS5, Line 126: implements
nit: implement
Done
https://review.coreboot.org/c/coreboot/+/48921/comment/80e2799e_79624912 PS5, Line 131: HAVE_ACPI_TABLES
I'd move this dependency to `HAVE_SCMI`, and adjust the select in CB:41735 accordingly: […]
Done - dependency moved to 41735 so this patch only adds the two Kconfig options.