Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47658 )
Change subject: commonlib/region: Allow multiple windows for xlate_region_dev
......................................................................
Patch Set 2:
(2 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/47658/1/src/commonlib/include/commo...
File src/commonlib/include/commonlib/region.h:
https://review.coreboot.org/c/coreboot/+/47658/1/src/commonlib/include/commo...
PS1, Line 217: * provided by access_dev. */
Agreed. As you noted, there are quite a few challenges/restrictions that this imposes. […]
Done
https://review.coreboot.org/c/coreboot/+/47658/1/src/commonlib/include/commo...
PS1, Line 235: window_count_
Can't this just use […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47658
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5b21ffca2c8d6a9dfc37a878429aed4a8301651
Gerrit-Change-Number: 47658
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 23 Nov 2020 18:48:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment