Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38715 )
Change subject: mb/google/volteer: use new tigerlake memory config ......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38715/14/src/mainboard/google/volte... File src/mainboard/google/volteer/romstage.c:
https://review.coreboot.org/c/coreboot/+/38715/14/src/mainboard/google/volte... PS14, Line 9: #include <assert.h> Probably not required anymore?
https://review.coreboot.org/c/coreboot/+/38715/14/src/mainboard/google/volte... PS14, Line 11: #include <cbfs.h> Probably not required anymore?
https://review.coreboot.org/c/coreboot/+/38715/14/src/mainboard/google/volte... PS14, Line 16: #include <string.h> Is this required?