Attention is currently required from: Furquan Shaikh, Subrata Banik, Patrick Rudolph, EricR Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56074 )
Change subject: mb/google/brya: Add UsbTcPortEn in devicetree ......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5: CB:55361 is already setting UsbTcPortEn...
I verified it on Brya: ``` diff --git a/src/soc/intel/alderlake/fsp_params.c b/src/soc/intel/alderlake/fsp_params.c index 5b0d63108b14..ac55ba9d00b1 100644 --- a/src/soc/intel/alderlake/fsp_params.c +++ b/src/soc/intel/alderlake/fsp_params.c @@ -307,6 +307,7 @@ static void fill_fsps_tcss_params(FSP_S_CONFIG *s_cfg,
s_cfg->UsbTcPortEn = 0; for (int i = 0; i < MAX_TYPE_C_PORTS; i++) { + printk(BIOS_INFO, "@@ TDW looking for usb3 port id %d: ", i); /* TCSS xHCI --> Root Hub --> Type-C Port */ const struct device_path port_path[] = { {.type = DEVICE_PATH_PCI, .pci.devfn = SA_DEVFN_TCSS_XHCI}, @@ -315,9 +316,15 @@ static void fill_fsps_tcss_params(FSP_S_CONFIG *s_cfg, const struct device *port = find_dev_nested_path(pci_root_bus(), port_path, ARRAY_SIZE(port_path));
- if (is_dev_enabled(port)) + if (is_dev_enabled(port)) { + printk(BIOS_INFO, "Found!\n"); s_cfg->UsbTcPortEn |= BIT(i); + } else { + printk(BIOS_INFO, "Non-existent or disabled\n"); + } } + + printk(BIOS_INFO, "@@ TDW UsbTcPortEn = 0x%x\n", s_cfg->UsbTcPortEn); } ```
``` @@ TDW looking for usb3 port id 0: Found! @@ TDW looking for usb3 port id 1: Found! @@ TDW looking for usb3 port id 2: Found! @@ TDW looking for usb3 port id 3: Non-existent or disabled @@ TDW UsbTcPortEn = 0x7 ```