[coreboot-gerrit] Change in coreboot[master]: drivers/mrc_cache: generate debug messages for MRC cache update

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41981 )

Change subject: drivers/mrc_cache: generate debug messages for MRC cache update
......................................................................

drivers/mrc_cache: generate debug messages for MRC cache update

When MRC cached data update is performed, messages are written to
event log, which is flash based. For system that does not have flash
based event log, the messages are lost.

Added corresponding BIOS_DEBUG messages.

Signed-off-by: Jonathan Zhang 
Change-Id: I1ef4794151fea7213c8317ddc898b0e37da280b5
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41981
Reviewed-by: Duncan Laurie 
Reviewed-by: Michael Niewöhner
Tested-by: build bot (Jenkins) 
---
M src/drivers/mrc_cache/mrc_cache.c
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Duncan Laurie: Looks good to me, approved
  Michael Niewöhner: Looks good to me, but someone else must approve

diff --git a/src/drivers/mrc_cache/mrc_cache.c b/src/drivers/mrc_cache/mrc_cache.c
index 4e6e91c..3a005db 100644
--- a/src/drivers/mrc_cache/mrc_cache.c
+++ b/src/drivers/mrc_cache/mrc_cache.c
@@ -397,6 +397,7 @@
    	return;

if (!mrc_cache_needs_update(&latest_rdev, to_be_updated)) {
+		printk(BIOS_DEBUG, "MRC: '%s' does not need update.\n", cr->name);
    	log_event_cache_update(cr->elog_slot, ALREADY_UPTODATE);
    	return;
    }
@@ -405,10 +406,13 @@

if (region_file_update_data(&cache_file,
    			cbmem_entry_start(to_be_updated),
-				cbmem_entry_size(to_be_updated)) < 0)
+				cbmem_entry_size(to_be_updated)) < 0) {
+		printk(BIOS_DEBUG, "MRC: failed to update '%s'.\n", cr->name);
    	log_event_cache_update(cr->elog_slot, UPDATE_FAILURE);
-	else
+	} else {
+		printk(BIOS_DEBUG, "MRC: updated '%s'.\n", cr->name);
    	log_event_cache_update(cr->elog_slot, UPDATE_SUCCESS);
+	}
 }

/* Read flash status register to determine if write protect is active */