31 May
2019
31 May
'19
8:56 p.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33152 )
Change subject: src/soc/intel: Fix Coverity scan report ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33152/2/src/soc/intel/broadwell/romstage/ram... File src/soc/intel/broadwell/romstage/raminit.c:
https://review.coreboot.org/#/c/33152/2/src/soc/intel/broadwell/romstage/ram... PS2, Line 126: if (!mem_info) Probably add a print indicating error adding cbmem entry?
--
To view, visit https://review.coreboot.org/c/coreboot/+/33152
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d78ab38b8b2dd3734e0143acfd88d9093f16ce6
Gerrit-Change-Number: 33152
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao john.zhao@intel.com
Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com
Gerrit-Reviewer: John Zhao john.zhao@intel.com
Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-Comment-Date: Fri, 31 May 2019 18:56:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment