Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39599 )
Change subject: nb/intel/sandybridge: Tidy up code and comments ......................................................................
Patch Set 4:
(6 comments)
https://review.coreboot.org/c/coreboot/+/39599/2/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/39599/2/src/northbridge/intel/sandy... PS2, Line 2280: return;
This change was to reduce the indentation of the write32 statement so that it fits on a single line. […]
Done
https://review.coreboot.org/c/coreboot/+/39599/2/src/northbridge/intel/sandy... PS2, Line 2881:
same
Done
https://review.coreboot.org/c/coreboot/+/39599/2/src/northbridge/intel/sandy... PS2, Line 3096:
Well, these were before I had the idea of renaming the macros so that they are the same length. […]
Done
https://review.coreboot.org/c/coreboot/+/39599/2/src/northbridge/intel/sandy... PS2, Line 3309: =
Ack. This was to have the statements naturally aligned. I'll use use a space.
I ended up placing a zero and a chain of or-statements. Thoughts?
https://review.coreboot.org/c/coreboot/+/39599/2/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_ivy.c:
https://review.coreboot.org/c/coreboot/+/39599/2/src/northbridge/intel/sandy... PS2, Line 389: }
yeah, rewriting this as a switch case statement would be nice. […]
Changes the binary 😞
https://review.coreboot.org/c/coreboot/+/39599/2/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_sandy.c:
https://review.coreboot.org/c/coreboot/+/39599/2/src/northbridge/intel/sandy... PS2, Line 188: 1400MHz (DDR3 2800)
Erm, I copypasta'd the comment from guess where. I'll fix that.
Done